Skip to content

OCPBUGS-77750: Auto-detect GNSS serial port by NIC#559

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
vitus133:nmea-port-4.21
Mar 16, 2026
Merged

OCPBUGS-77750: Auto-detect GNSS serial port by NIC#559
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
vitus133:nmea-port-4.21

Conversation

@vitus133
Copy link
Contributor

@vitus133 vitus133 commented Mar 5, 2026

Address the problem of randomly changing GNSS device names after host reboot. Use ts2phc configuration to determine the operation mode and the clock chain leading NIC. In the T-GM case, find the GNSS device by browsing the leading NIC SysFS structure. Add the discovered serial port address to ts2phc.conf.
The mechanism only works if ts2phc.nmea_serialport setting is omitted from the PTP profile. If the setting is present, it acts as before the change, leaving "Automatic" Vs. "Manual" setting decision to user.

Assisted by Cursor AI

@vitus133
Auto-detect GNSS serial port by NIC
994e673 
Address the problem of randomly changing GNSS device names after host
reboot. Use ts2phc configuration to determine the operation mode and
the clock chain leading NIC. In the T-GM case, find the GNSS device
by browsing the leading NIC SysFS structure. Add the discovered serial
port address to ts2phc.conf.
The mechanism only works if `ts2phc.nmea_serialport` setting is omitted
from the PTP profile. If the setting is present, it acts as before the
change, leaving "Automatic" Vs. "Manual" setting decision to user.

Assisted by Cursor AI

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 5, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2026

@vitus133: This pull request references Jira Issue OCPBUGS-77750, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.z" instead
  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Address the problem of randomly changing GNSS device names after host reboot. Use ts2phc configuration to determine the operation mode and the clock chain leading NIC. In the T-GM case, find the GNSS device by browsing the leading NIC SysFS structure. Add the discovered serial port address to ts2phc.conf.
The mechanism only works if ts2phc.nmea_serialport setting is omitted from the PTP profile. If the setting is present, it acts as before the change, leaving "Automatic" Vs. "Manual" setting decision to user.

Assisted by Cursor AI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from josephdrichard and jzding March 5, 2026 12:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@vitus133
Copy link
Contributor Author

vitus133 commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2026

@vitus133: This pull request references Jira Issue OCPBUGS-77750, which is invalid:

  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nocturnalastro
Copy link
Contributor

nocturnalastro commented Mar 16, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 16, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 16, 2026

@nocturnalastro: This pull request references Jira Issue OCPBUGS-77750, which is valid. The bug has been moved to the POST state.

9 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-77751 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent bug Jira Issue OCPBUGS-77751 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-77751 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • dependent Jira Issue OCPBUGS-77751 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @yliu127

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yliu127 March 16, 2026 13:12
@nocturnalastro
Copy link
Contributor

nocturnalastro commented Mar 16, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 16, 2026
@nocturnalastro
Copy link
Contributor

nocturnalastro commented Mar 16, 2026

/lgtm

@nocturnalastro
Copy link
Contributor

nocturnalastro commented Mar 16, 2026

/verified later @Bonnie-Block

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 16, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 16, 2026

@nocturnalastro: This PR has been marked to be verified later by @Bonnie-Block.

Details

In response to this:

/verified later @Bonnie-Block

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nocturnalastro
Copy link
Contributor

nocturnalastro commented Mar 16, 2026

/lgtm

nocturnalastro
nocturnalastro approved these changes Mar 16, 2026
View reviewed changes
Copy link
Contributor

@nocturnalastro nocturnalastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nocturnalastro, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [nocturnalastro,vitus133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cb9d25c into openshift:release-4.21 Mar 16, 2026
7 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 16, 2026

@vitus133: Jira Issue OCPBUGS-77750: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-77750 has been moved to the MODIFIED state.

Details

In response to this:

Address the problem of randomly changing GNSS device names after host reboot. Use ts2phc configuration to determine the operation mode and the clock chain leading NIC. In the T-GM case, find the GNSS device by browsing the leading NIC SysFS structure. Add the discovered serial port address to ts2phc.conf.
The mechanism only works if ts2phc.nmea_serialport setting is omitted from the PTP profile. If the setting is present, it acts as before the change, leaving "Automatic" Vs. "Manual" setting decision to user.

Assisted by Cursor AI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephdrichard josephdrichard Awaiting requested review from josephdrichard

@jzding jzding Awaiting requested review from jzding

@yliu127 yliu127 Awaiting requested review from yliu127

1 more reviewer

@nocturnalastro nocturnalastro nocturnalastro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@gsr-shanks gsr-shanks

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@obochan-rh obochan-rh

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.